Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NLopt's ESCH, ISRES, CRS2-LM, PRAXIS, and randomized DIRECT algorithms use randomness but their optimagic wrappers do not expose a seed. This can make optimization results vary between runs and causes the ESCH binding-bounds test to fail intermittently.
Add an optional 32-bit seed to those wrappers and initialize NLopt's generator in the shared optimization function. The existing generic optimizer tests use a fixed seed when an algorithm exposes one. Document that NLopt shares random state between optimizer calls on the same thread on supported builds, including nested optimizations. Deterministic DIRECT variants leave the random state alone.
NLopt 2.10.1 selects deterministic unscaled DIRECT-L for all unscaled DIRECT variants, including the randomized one, so its seed cannot change the search. This upstream issue has been corrected on NLopt's development branch and is documented here.
Validation
pixi run -e type-checking tyand repository pre-commit checks pass.