Conversation
gest-api is imported unconditionally by optimas.generators.base, optimas.diagnostics.exploration_diagnostics, and every bundled generator, but it was never declared in the project metadata. As a result, `pip install optimas` produces an installation where importing any generator raises ModuleNotFoundError. CI masked this by installing gest-api explicitly after `pip install .[test]`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gest-api is now pulled in by `pip install .[test]`, so installing it separately is no longer needed. Removing it also lets CI exercise the declared project metadata rather than masking a missing dependency. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
All names optimas imports from gest_api (VOCS, ContinuousVariable, DiscreteVariable, MinimizeObjective, ExploreObjective and Generator) are already present in gest-api 0.1, so requiring 0.2 would needlessly exclude a working version. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gest-apiis imported unconditionally byoptimas.generators.base, optimas.diagnostics.exploration_diagnostics, and every bundled generator, but it was never declared in the project metadata. As a result,pip install optimasproduces an installation where importing any generator raisesModuleNotFoundError.CI masked this by installing gest-api explicitly after
pip install .[test].