Repository navigation
Conversation
Signed-off-by: Akshat Rampuria <akshat.rampuria@oracle.com>
dustin-sale
left a comment
There was a problem hiding this comment.
Review by @dustin-sale via Codex.
Requested changes
src/oci-recovery-mcp-server/scripts/install_oci_recovery_mcp.py:290— [P1] Persist the session in the config file used by the generated MCP configuration.
Additional review notes
src/oci-recovery-mcp-server/scripts/install_oci_recovery_mcp.py:336— [P2] Render the Windows refresh command for PowerShell.
Validation
Lint and all 215 Recovery tests passed at the package's 100% coverage gate. The new installer helper is absent from that coverage report. Locked server installation and targeted configuration probes completed; live browser authentication and full Linux/Windows installation were not run.
See the inline comments in this review for evidence, impact, and suggested remediation.
dustin-sale
left a comment
There was a problem hiding this comment.
Review by @dustin-sale via Codex.
Requested changes
No blocking changes requested.
Additional review notes
Both previous findings are addressed: authentication and refresh consistently pass the selected config location, and Windows refresh commands use PowerShell invocation and quoting. Regression tests cover both fixes. No additional actionable findings from the full installer follow-up pass.
Validation
Lint and all 217 Recovery tests passed, with 100% server-runtime branch coverage; the standalone installer is explicitly excluded from that coverage calculation. An independent OCI CLI probe verified both custom-config environment variables. Live browser authentication and complete Linux/Windows installation remain untested.
Description
Adds a package-local installer bundle for OCI Recovery MCP on macOS, Linux, and Windows. Users can receive the three files together; the launchers run the adjacent Python helper without fetching installer code from GitHub.
The installer clones or updates the repository’s
mainbranch in.local-rcv-mcp, installs the Recovery server in its project environment, and uses the OCI CLI fromPATHor installs it in an isolated environment. It suggestsOCI_RECOVERYas the profile name, then runsoci session authenticate --profile-name <name>so the OCI CLI can prompt for the region. It prints configuration for Claude, Codex, Cursor, and Cline.No Recovery package dependencies were added. Installation requires Git and internet access; the launchers can install
uv, Python 3.13, and OCI CLI when needed.Type of change
How Has This Been Tested?
sh -n src/oci-recovery-mcp-server/scripts/install-oci-recovery-mcp.sh— passed--help— passedgit diff origin/main...HEAD --check— passedmoon run root:lintcould not complete in this environment: Moon/proto attempted to write outside the workspace, and the Ruff fallback could not download because of a network/DNS failure.Test Configuration:
shandpython3; PowerShell parser unavailableChecklist