Repository navigation
docs: provide a self-contained public sample without obsolete handoffs - #18
Merged
Merged
Conversation
fakayser
changed the title
fakayser
marked this pull request as ready for review
November 5, 2026 08:23
fakayser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README provides task-based routes and a short local first-success path. Use the public CLI's builtin:SQLServer and sql extra; retain saved type mappings, model scope and all three targets. Remove the external connector download script/lockfile.
Generated SQL readers and the manifest now consume builtin:SQLServer directly. Remove source_reader_kind and its ID translation. Connection binding names remain explicitly configured by the sample; source APIs are unchanged.
Remove temporary local test approval/model-handoff gates and obsolete cleanup/documentation handoffs, including their incoming links. PR/main checks run with public locked dependencies and no cloud credentials.
Validation: 14 Python fixture tests passed, all three targets (Databricks, Power BI, Docs) validated/generated, 5 documentation regression tests passed and 21 Markdown files checked without problems. SQL reader tests exercise quoted identifiers and filters using the actual shared reader with synthetic Spark/secret/database responses. Disposable copies and public dependencies only; no cloud/live source operation. Technical and editorial changes are separate commits. Manual maintainer merge.