Repository navigation
ci: post the discipline sentinel report as a PR comment - #219
Merged
Merged
Conversation
Enable the discipline action's comment:true input on the Discipline Sentinel job. The full report is now posted as one pull-request comment, edited on every run, so reviewers see the verdict on the thread instead of chasing the job log. The job's pull-requests permission goes read -> write, so its checkout must not persist credentials (DISCIPLINE_FORGE_TOKEN carries the token in env); a fork's read-only token is reported, not failed, so comment posting can never block a fork pull request.
discipline: passedBase
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Turns on the discipline action's
comment: trueinput on the Discipline Sentinel job (.github/workflows/ci.yml).Why
Reviewers currently see the sentinel verdict only in the job log / step summary. With
comment: true, the full report is posted as one pull-request comment, edited on every run — the verdict lands on the thread automatically.Changes
comment: trueon the sentinel stepdisciplinejob permissions:pull-requests: read→write(comment posting)persist-credentials: falseon the job's checkout: the discipline action reads the forge throughDISCIPLINE_FORGE_TOKEN(env), not git credentials, so the token is kept out of.git/confignow the job can write (flagged by the v0.15+ci-integritycheckout-persists-credentialsfinding — itself a new-gate catch from the ci: bump discipline action pins from v0.14.4 to v0.18.0 #218 bump)Validation
discipline check --base origin/main: PASS (27 gates, 0 errors, 0 warnings, 0 overrides)The
ci-integritycheckout-persists-credentialsfinding this change initially tripped is resolved by thepersist-credentials: falseabove; note the bump in #218 is what armed that finding.