Repository navigation
Conversation
## Motivation
Both formatters use `isNaN(Number(v))` to decide whether a value is numeric, but `Number('')` and
`Number(null)` are both `0`, so an empty cell slips through:
```ts
percentageValueFormat('') // '0' - an empty cell rendered as 0%
formatNegativeNumber(true, ['']) // [-0] - an empty cell rendered as -0
formatNegativeNumber(true, [null])// [-0]
```
A missing data point therefore shows up as a real `0` (or `-0`) in the chart legend and tooltip,
which reads as "measured as zero" rather than "no data".
## Change
Return the value untouched when it is `''`, `null` or `undefined`, before the numeric path.
## Verification
```
# tests only
Tests: 2 failed, 3 passed, 5 total
# with the fix
Tests: 5 passed, 5 total
```
Signed-off-by: Yxq <yu2651701064@tju.edu.cn>
|
@tju-yxq is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Both formatters use
isNaN(Number(v))to decide whether a value is numeric, butNumber('')andNumber(null)are both0, so an empty cell slips through:A missing data point therefore shows up as a real
0(or-0) in the chart legend and tooltip,which reads as "measured as zero" rather than "no data".
Change
Return the value untouched when it is
'',nullorundefined, before the numeric path.Verification