Repository navigation
Conversation
The card is titled and weighted as Bug Issue Open Time
(community_service_and_support.metrics.bug_issue_open_time), but its chart
tabs read metricCommunity.issueOpenTimeAvg/Mid and
summaryCommunity.issueOpenTimeAvg/Mid - the open time of ALL issues. The
GraphQL layer declares bugIssueOpenTimeAvg { mean, median } and
bugIssueOpenTimeMid in both metricCommunity (query.graphql:174-175) and
summaryCommunity (:361-364), and a grep shows the bug* fields are consumed
nowhere in the app - the card, its avg/median summary reference lines and
the downloaded image all render the wrong series.
Switch the four keys to bugIssueOpenTime*, and extract the tab map into an
exported getChartTabs(t) factory so the key contract is testable (same
pattern as the merged oss-compass#407 processLanguages export).
|
@zjncs is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The card is titled and weighted as Bug Issue Open Time (
community_service_and_support.metrics.bug_issue_open_time), but its chart tabs readmetricCommunity.issueOpenTimeAvg/MidandsummaryCommunity.issueOpenTimeAvg/Mid- the open time of all issues. The GraphQL layer declaresbugIssueOpenTimeAvg { mean, median }andbugIssueOpenTimeMidin bothmetricCommunity(packages/graphql/src/gql/query.graphql:174-175) andsummaryCommunity(:361-364), and a grep shows thebug*fields are consumed nowhere in the app - so the chart, its avg/median summary reference lines and the downloaded image all render the wrong series.Fix
Switch the four keys to
bugIssueOpenTime*, and extract the tab map into an exportedgetChartTabs(t)factory so the key contract is testable (same pattern as the merged #407processLanguagesexport).Verification
BugIssueOpenTime.test.tsx: RED before (keys wereissueOpenTime*), GREEN after.intelligent-analysis/server/pathSafetyfailure is pre-existing on main and unrelated - a Windows path-separator issue).Risk
The card now renders the series its title promises. No other consumer of the old keys in this card's context.