Repository navigation
Conversation
subscribeKey is called in the render body and its returned unsubscribe is discarded: every re-render of every mounted ScoreConversion (used on nearly all analyze chart cards) adds another permanent subscription with a stale onePoint/onChange closure. One navbar toggle of the score system then fans out to N accumulated callbacks (N = renders so far), which keep firing after unmount. Move the subscription into useEffect with cleanup. Red proof in the test: rendering 4 times and flipping chartUserSettingState.onePointSys fires onChange 4 times before the fix, exactly once after.
|
@zjncs is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
subscribeKeyis called in the render body and its returnedunsubscribeis discarded: every re-render of every mountedScoreConversion(used on nearly all analyze chart cards -TableList,TotalScore,LineChart, ...) adds another permanent subscription with a staleonePoint/onChangeclosure. One navbar toggle of the score system (ChartDisplaySettingwriteschartUserSettingState.onePointSys) then fans out to N accumulated callbacks (N = total renders so far), which keep firing after unmount.Fix
Move the subscription into
useEffectwith cleanup (deps[onePoint, onChange]).Verification
ScoreConversion.test.tsx, RED proof: render 4x with stable props, flipchartUserSettingState.onePointSys- onChange fires 4 times before the fix (valtio notifies via microtask, the test flushes withact), exactly once after.Risk
None identified - subscription semantics unchanged for the single-mount case.