Repository navigation
Conversation
…etting TableList 的 onePointSys 用 useState(false) 硬编码百分制：用户在导航栏 切换过 1 分制并已持久化（chartUserSettingState.onePointSys 写入 localStorage['analyze.setting.chart']）后，概览表格仍以百分制渲染， 而正上方的图表（useGetLineOption / OverviewSummary/LineChart 均以 chartUserSettingState.onePointSys 初始化）以 1 分制渲染——同一屏两种 分制，直到用户手动再切换一次。 与两个兄弟组件一致地以 store 值作为初值。
|
@zjncs is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TableList'sonePointSysis hardcoded withuseState(false)(hundred-mark). The user's score-system choice is settable from the navbar (ChartDisplaySettingwriteschartUserSettingState.onePointSys) and persisted tolocalStorage['analyze.setting.chart']— but the overview table ignores it on mount: a user whose saved setting is the 1-point system sees the table render 0-100 scores while the chart directly above it (useGetLineOptionandOverviewSummary/LineChartboth initialize fromchartUserSettingState.onePointSys) renders 0-1 scores — two score systems on the same screen until the user toggles again.Fix
Initialize the state from the store, mirroring the two sibling components.
Verification
TableList.test.tsx: setchartUserSettingState.onePointSys = true, render, assert the score-conversion label shows the point-system marker (analyze:mark.point) — RED before (showedanalyze:mark.percentage), GREEN after.intelligent-analysis/server/pathSafety) is pre-existing on main (Windows path separator) and unrelated.Risk
None identified — aligns the table with its siblings' initialization.