Repository navigation
Conversation
useTopicNavbarScroll 对 topic_overview 卡片硬编码返回英文字符串
'Overview'：中文环境下吸顶面包屑显示 "Overview / 稳健性" 中英混排，
且 TopicNavbar 图标映射里的 '概览' 分支成为死代码（其余标题均取自
卡片标题的 DOM 文本，天然本地化）。
改用 t('analyze:overview')（LineChart.tsx:45 已使用同一键）。
|
@zjncs is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
useTopicNavbarScrollreturns a hardcoded English string'Overview'for thetopic_overviewcard. In the zh locale the sticky breadcrumb shows "Overview / 稳健性" (mixed languages), and the'概览'icon branch inTopicNavbar's icon map is dead code (every other title comes from the localized DOM text of the card headers, so this is the only untranslated entry).Fix
Use
t('analyze:overview')— the same keyLineChart.tsx:45already uses.Verification
useTopicNavbarScroll.test.tsx: hook-level test with mocked i18n, a#topic_overviewcard in view and a scrolled window — asserts the resolved title is the translated key. RED before (returned the literal'Overview'), GREEN after.Risk
None identified — the icon map keeps both spellings, and zh users now hit the existing
概览branch.