Repository navigation
Conversation
Signed-off-by: PointerL <lixuexin130@163.com>
|
@PointerL is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @coder-sett, a gentle reminder that the GitHub Actions run for this PR is still awaiting maintainer approval ( This contribution is intended for the 2026 直通乌镇 open-source competition, whose OSS Compass submission window requires the contribution to be merged before 2026-10-25 00:00. I would appreciate a workflow approval or review when convenient. Thank you! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbortSignal.timeoutAPIRoot cause
The runtime feature check was safe, but the repository uses TypeScript 4.9.5, whose DOM declarations do not include the static
AbortSignal.timeoutmethod. As a result, both the feature check and method call produced TS2339 diagnostics.The fix keeps the type adaptation local to
openContainerChannel, avoiding a global declaration or TypeScript/lib upgrade.Validation
Passed:
node --max-old-space-size=8192 node_modules/typescript/bin/tsc --noEmit --lib DOM,ES2020 --target ES2020 --module ESNext --strict --skipLibCheck apps/web/src/modules/intelligent-analysis/UserJourney/rawData/apiClient.tsnode node_modules/lint-staged/bin/lint-staged.jsgit diff --checkFull-repository checks also found unrelated baseline/environment issues:
yarn test:ci: 140/141 tests passed; the only failure is the existing POSIX-path assertion inpathSafety.test.tswhen run on Windowstsc --noEmit: the two docs(issue): apps/web 的 tsc --noEmit 目前不通过,AbortSignal.timeout 缺少类型 #577 TS2339 diagnostics are gone; seven unrelated diagnostics remain in translation typing,EvaluationMerticList,_app.tsx, andtsconfig.jsonnext build: compilation succeeded, but Windows final build tracing hit the OSEMFILEfile-handle limitNo runtime unit test was added because the runtime branches are unchanged; the regression is the TypeScript declaration compatibility itself.
AI assistance
Codex was used to inspect the issue and repository guidance, implement the local type adaptation, run validation, and draft this description. The contributor reviewed the diff and validation results.
Fixes #577