Repository navigation
Conversation
Signed-off-by: llemmm <165860939+llemmm@users.noreply.github.com>
|
@llemmm is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Shift+Enter and Ctrl+Enter in the Lab, Sandbox, Hatch and Graduate comment inputs always append a newline to the end of the comment. They ignore the caret position and leave selected text intact.
Reproduction
abcdefin a comment input.candd, then press Shift+Enter or Ctrl+Enter.abcdef\ninstead ofabc\ndef.cdand using either shortcut should replace the selection with a newline, but the original code appends one instead.Change
Only four comment components and one test file change. IME handling, attachment limits and attachment deletion behavior are intentionally unchanged; this is separate from the IME guards in #480.
Validation
4f2d8aced18cf5e71928f1e7931525ac6f7d8293: 31 suites / 136 tests pass.5bc4a58a814baae4c5eabf197347be4cf43635ee: 32 suites / 176 tests pass.yarn buildpasses, including default lint/type checking and production build steps.react-hooks/exhaustive-depswarning about the Lab component'sboxRef.currentcleanup remains unchanged. Original files were separately linted through stdin with their actual filenames and the same configuration. No rules or warnings were suppressed, and unrelated cleanup code was not changed.DCO
The commit contains the contributor's explicitly authorized
Signed-off-bytrailer, using their GitHub privacy email.