Jitter framework-level AWS retry delays - #453
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The framework-level retry helper waits a fixed five seconds between attempts, so the many deploys that a single throttling event affects all retry in lockstep and are throttled again together. v3 spread its retries across a four to seven second window. This applies the same spread to the helper by jittering each wait uniformly between 0.8 and 1.4 times the base delay, which keeps the four to seven second window for throttling retries, and logs the actual wait. The transient network retry picks up the same jitter, which is harmless. Tests that shorten the delay to a millisecond are unaffected.