Skip to content

MIDI: sysex to the graph, removed devices, latency, loop WAV writer - #965

Merged
jcelerier merged 16 commits into
masterfrom
feature/midi-effects
Oct 28, 2026
Merged

MIDI: sysex to the graph, removed devices, latency, loop WAV writer#965
jcelerier merged 16 commits into
masterfrom
feature/midi-effects

Conversation

@jcelerier

@jcelerier jcelerier commented Oct 25, 2026

Copy link
Copy Markdown
Member

Engine changes for score's MIDI effects and loopers.

  • Sysex reaches the graph: MIDI inputs ask the backend for sysex (it was dropped) and pass each UMP packet on its own (it was cut to the first packet). A port bound to a MIDI channel takes only channel messages.
  • Removed MIDI devices are never read: each MIDI inlet records the stream it registered with; unregistering it uses that record, and a removed device's stream is dropped when the change is applied, now at the start of the tick. Fixes a crash when a document whose processes read a MIDI device is closed.
  • Midi node: note-on and note-off stamps stay inside their own tick.
  • Audio latency: audio_engine reports input / output latency (PortAudio; JACK, kept current by a latency callback, stored in atomics), exposed on execution_state.
  • write_loop_wav: 32-bit float WAV loops with ACID tempo and an smpl loop; RF64 past 4 GB; a file that failed to write is removed.
  • SDK: Qt QML headers installed when OSSIA_QML is on.
  • libremidi bumped: Pitch bend upscale and whole sysex across MIDI 1 and MIDI 2 celtera/libremidi#268.

Tested through score (ossia/score feature/midi-effects): 105 targeted test programs pass, including new execution_state tests for stale MIDI devices and closing a playing document.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr

@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 04:56 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 04:56 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 04:56 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 04:56 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 04:56 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 04:56 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 04:56 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 04:56 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 04:56 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 04:56 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 04:56 — with GitHub Actions Inactive
@jcelerier jcelerier mentioned this pull request Oct 25, 2026
Open
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 10:49 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 10:49 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 10:49 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 10:49 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 10:49 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 10:49 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 10:49 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 10:49 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 10:49 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 10:49 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 13:14 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 14:12 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 14:12 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 14:12 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 14:12 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 14:12 — with GitHub Actions Inactive
@jcelerier
jcelerier temporarily deployed to Apple Certificate October 25, 2026 14:12 — with GitHub Actions Inactive
jcelerier and others added 13 commits October 27, 2026 22:59
@jcelerier @claude @xxxxxxxxxxxxx
bump libremidi: pitch bend keeps its center through MIDI 2
913ac5e 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude @xxxxxxxxxxxxx
audio: write_loop_wav, float WAV files with ACID tempo and a sampler …
55b9663 
…loop

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude @xxxxxxxxxxxxx
audio: input and output latency as JACK and PortAudio report them, on…
088668e 
… the execution state

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude @xxxxxxxxxxxxx
midi node: note-ons and note-offs stamped inside the tick they fall in
c88efdc 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude @xxxxxxxxxxxxx
audio: JACK latency kept current, loop WAVs past 4 GB
3c0bd10 
- JACK recomputes port latencies on its own thread when the graph changes;
  a latency callback stores them in atomics the engine reads.
- write_loop_wav writes RF64 when the data does not fit a RIFF header, and
  removes a file it failed to finish.
- libremidi: one 14 to 32 bit upscale for pitch bend.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude @xxxxxxxxxxxxx
execution_state: MIDI inlets never read a removed device
eb57a96 
An inlet's MIDI stream is recorded when it registers, and unregistering it
uses that record rather than its address, whose device may be destroyed by
then. A removed device's stream is dropped when the device change is
applied, which now happens before a tick reads the streams.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude @xxxxxxxxxxxxx
midi: system exclusive reaches the graph
525980c 
MIDI inputs ask the backend for sysex, and pass each UMP packet of it on
its own: a full-frame timecode was dropped by the backend, then truncated
to its first packet. A port bound to a channel takes only channel
messages, so sysex no longer leaks into it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude @xxxxxxxxxxxxx
bump libremidi: MIDI effects work on its current master
1ed9357 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude @xxxxxxxxxxxxx
bump libremidi
d444f57 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude @xxxxxxxxxxxxx
bump libremidi
827ca71 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude @xxxxxxxxxxxxx
execution_state: a MIDI stream registered again in the same batch kee…
29e9b3b 
…ps its inlets

A device removed and registered again before a tick, or a new one
allocated where the old one was, kept losing the inlets already bound to
it: the removal erased them after they had registered.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude @xxxxxxxxxxxxx
libremidi: MIDI 1 outputs send sysex whole
b21c8c7 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude
libremidi: stream decoder fixes, on its current master
cf0291a 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier
jcelerier force-pushed the feature/midi-effects branch from 5d0e2d0 to cf0291a Compare October 28, 2026 03:11
@jcelerier
jcelerier deployed to Apple Certificate October 28, 2026 03:43 — with GitHub Actions Active
jcelerier and others added 2 commits October 28, 2026 09:31
@jcelerier @claude
libremidi: master, with the stream decoder tests named by what they c…
b6b1a4d 
…heck

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr
@jcelerier @claude
token_request: a tick split at a date keeps its musical positions
64a7ee1 
set_start_time and set_end_time scaled the musical position by t / date,
which only holds when the position is proportional to the date. An item
that starts later than musical time, e.g. a box later in a scenario, has
dates relative to itself and quarters relative to the timeline: a looper
there split at a grid point got a start of 18.45 quarters for 17. The
position is now interpolated within the tick, as the frames are.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qr9WkcUjEGCueg7eG1KxSr

This branch was successfully deployed

1 active deployment
Apple Certificate — 64a7ee1a Deployed Oct 28, 2026 by jcelerier via build-macos (0, Debug) #1320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jcelerier