Repository navigation
Export ossia::nodes::automation and ossia::curve - #967
Merged
Merged
Conversation
Both are defined in headers only, so with -fvisibility=hidden every shared object that uses them gets its own local typeinfo. A dynamic_cast from graph_node / curve_abstract in another shared object (score's unit tests reading the automation node and curve its executor built) compares typeinfo by address on ELF and fails. Export them like their header-only siblings simple_mapping and domain_base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JeL19ofVgPe9u9q7J1V9ex
jcelerier
temporarily deployed
to
Apple Certificate
October 26, 2026 22:56 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 26, 2026 22:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 26, 2026 22:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 26, 2026 22:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 26, 2026 22:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 26, 2026 22:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jcelerier
had a problem deploying
to
Apple Certificate
October 26, 2026 22:56 — with
GitHub Actions
Failure
GitHub Actions
Failure
jcelerier
temporarily deployed
to
Apple Certificate
October 26, 2026 22:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 26, 2026 22:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 26, 2026 22:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 26, 2026 22:56 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both are header-only, so with
-fvisibility=hiddenevery shared object that uses them gets its own local typeinfo. Adynamic_castfromgraph_node/curve_abstractin another shared object compares typeinfo by address on ELF and fails. This shows up in score's unit tests (test_unit_curve_edition,test_unit_scriptable_controls) on a shared-plugin build, which read the automation node and the curve its executor built.Exports them the same way as their header-only siblings
simple_mappinganddomain_base. No effect on static builds (the macro expands to nothing there).Needed by ossia/score's
bugfix/shader-ledgerPR, which bumps the submodule to this commit.🤖 Generated with Claude Code
https://claude.ai/code/session_01JeL19ofVgPe9u9q7J1V9ex