Repository navigation
dataflow: the port address list is read again when it opens; the full address is its tooltip - #2334
Draft
edumeneses wants to merge 1 commit into
Draft
edumeneses wants to merge 1 commit into
edumeneses wants to merge 1 commit into
Conversation
… address is its tooltip The audio device does not report the ports it adds, removes or changes (its ossia callbacks are off), so a combo box already shown, e.g. a mixer bus, did not list a virtual port made afterwards until it was built again. The list is now rebuilt when the drop-down opens, keeping any text being typed. A narrow combo box, a bus strip in the mixer, cuts the address; hovering it shows the whole address. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lc7tYGHRn6TmaxMEfBTswW
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing the mixer (#2302): a bus's address combo box did not list a virtual port created after the strip was built, until the bus was deleted and made again. The same happens in the inspector of any audio port.
Why:
PortAddressComboBoxreloads on the device'spathAdded/pathRemoved/pathUpdated. The audio device never emits them, since its ossia callbacks are off. Turning them on, or emitting these signals by hand fromAudioDevice, would also make the device explorer apply the changes a second time, throughDeviceDocumentPlugin's queued handlers.Change:
showPopup), so it lists what the devices hold at that moment, whatever they report. Text being typed is kept.Test:
test_unit_port_address_combochecks that:It fails without the change.
test_unit_port_address_liststill passes.Opened by Edu's Claude assistant.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Lc7tYGHRn6TmaxMEfBTswW