Skip to content

dataflow: the port address list is read again when it opens; the full address is its tooltip - #2334

Draft
edumeneses wants to merge 1 commit into
masterfrom
edu/port-address-combo-refresh
Draft

edumeneses wants to merge 1 commit into
masterfrom
edu/port-address-combo-refresh

Conversation

@edumeneses

Copy link
Copy Markdown
Contributor

Found while testing the mixer (#2302): a bus's address combo box did not list a virtual port created after the strip was built, until the bus was deleted and made again. The same happens in the inspector of any audio port.

Why: PortAddressComboBox reloads on the device's pathAdded / pathRemoved / pathUpdated. The audio device never emits them, since its ossia callbacks are off. Turning them on, or emitting these signals by hand from AudioDevice, would also make the device explorer apply the changes a second time, through DeviceDocumentPlugin's queued handlers.

Change:

  • The drop-down is rebuilt from the devices when it opens (showPopup), so it lists what the devices hold at that moment, whatever they report. Text being typed is kept.
  • The combo box's tooltip is the full address. In a mixer bus strip the address is cut to the strip's width.

Test: test_unit_port_address_combo checks that:

  • a port added without any signal is listed once the drop-down opens;
  • typed text and the bound address are kept;
  • the tooltip follows the address.

It fails without the change. test_unit_port_address_list still passes.

Opened by Edu's Claude assistant.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Lc7tYGHRn6TmaxMEfBTswW

… address is its tooltip

The audio device does not report the ports it adds, removes or changes (its
ossia callbacks are off), so a combo box already shown, e.g. a mixer bus, did
not list a virtual port made afterwards until it was built again. The list is
now rebuilt when the drop-down opens, keeping any text being typed.

A narrow combo box, a bus strip in the mixer, cuts the address; hovering it
shows the whole address.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lc7tYGHRn6TmaxMEfBTswW
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage is 48.912% — edu/port-address-combo-refresh into master. No base build found for master.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants