Repository navigation
audio: a smaller channel count in the PipeWire and JACK settings is applied - #2335
Draft
edumeneses wants to merge 1 commit into
Draft
edumeneses wants to merge 1 commit into
edumeneses wants to merge 1 commit into
Conversation
…pplied AddRemoveList::setCount said when it added names and not when it removed them. Going from 64 outputs to 2 changed DefaultOut but left the 64 saved output names, and the engine opens as many channels as there are names: it kept 64, and the settings showed 64 names again once applied. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lc7tYGHRn6TmaxMEfBTswW
|
Coverage is 48.535% — edu/audio-channel-count-shrink into master. No base build found for |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing the mixer (#2302): in the audio settings (PipeWire or JACK), going from 64 outputs to 2 and confirming kept 64 outputs. When the settings were opened again, the list below the count showed the 64 names, and so did the mixer.
Why:
AddRemoveList::setCountemitschangedfor each name it adds, but not when it removes names.DefaultOut, but notOutputNames.PipeWireAudioFactory::make_engineand the JACK one open one channel per saved name, then pad up toDefaultOut. So the 64 names won.Change:
setCountemitschangedonce after removing names. The settings then save the shorter list, as they already did for a longer one. A configuration already stuck with extra names is fixed by opening the settings and confirming them, because building the page trims the list to the count.Test:
test_unit_add_remove_listchecks that:Opened by Edu's Claude assistant.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Lc7tYGHRn6TmaxMEfBTswW