Repository navigation
audio: an unlinked PipeWire output meters only what is sent to it - #2336
Draft
edumeneses wants to merge 1 commit into
Draft
edumeneses wants to merge 1 commit into
edumeneses wants to merge 1 commit into
Conversation
PipeWire hands no buffer to an output port that nothing is linked to, and libossia pointed all of them at one discard buffer: a signal sent to /out/1 showed on the meter of every unlinked output, and a stereo source on a third channel too. libossia now gives each one its own (ossia/libossia#961). The PipeWire tests check that two missing channels get distinct scratch, and, against a private daemon with no sink, that three unlinked outputs each keep what the tick wrote to them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lc7tYGHRn6TmaxMEfBTswW
|
Coverage is 48.526% — edu/pipewire-unlinked-outputs into master. No base build found for |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps libossia to ossia/libossia#961 and adds its tests.
PipeWire gives no buffer to an output port that nothing is linked to, and libossia pointed every such output at one shared discard buffer. Nothing reads those ports, so nobody hears it, but the mixer's hardware output meters read the tick's outputs after the mix. Edu hit it testing the mixer (#2302) with score's PipeWire outputs unlinked:
/out/1lit every channel's meter;libossia now gives each missing output its own scratch block.
Tests:
test_unit_pipewire_quantum: two missing channels get distinct scratch.test_unit_pipewire_protocol_quantum: against a private daemon with no sink, three unlinked outputs each keep what the tick wrote to them. It fails without the libossia change.The libossia pointer is #961's branch, merged with the commit master points at; it moves to libossia master once #961 lands.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Lc7tYGHRn6TmaxMEfBTswW