Repository navigation
libossia: ship the Qt QML headers in the SDK - #2352
Merged
Merged
Conversation
Points to libossia master's install fix (ossia/libossia#964). The SDK installed js_utilities.hpp, which includes ossia-qt/qml_context.hpp under QT_QML_LIB, without installing that header, so an add-on linking score_plugin_js against the SDK failed with "'ossia-qt/qml_context.hpp' file not found" (score-addon-py). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sZwhLYYDxKd7Ei5rbEpZJ
|
coverage: 48.868% (-0.3%) from 49.16% — libossia/install-qml-headers into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps libossia to the merge of ossia/libossia#964 (plus one docs commit that sat between the old pin and it).
The SDK shipped
js_utilities.hpp, which includesossia-qt/qml_context.hppunderQT_QML_LIB, without shipping that header. Any add-on that buildsscore_plugin_jscode against the SDK stopped with'ossia-qt/qml_context.hpp' file not found— score-addon-py#7 on all three SDK legs. Once this is in and the continuous SDK is republished, those legs can go green.🤖 Generated with Claude Code
https://claude.ai/code/session_011sZwhLYYDxKd7Ei5rbEpZJ