Repository navigation
qt-patches: Vulkan beginExternal in a compute pass, GL multisample min filter - #48
Merged
Merged
Conversation
…n filter qtbase 0013: maybeRenderTargetData() asserted a current target before checking for a render pass, so beginExternal() inside a compute pass aborted debug builds. qtbase 0014: QGles2Texture::create() set GL_TEXTURE_MIN_FILTER on multisample textures, raising GL_INVALID_ENUM for every MSAA texture. Both apply on the pinned qtbase after 0001-0012; see the README entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JeL19ofVgPe9u9q7J1V9ex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two qtbase fixes found while fuzzing score 3.9 on a debug, assertion-enabled build of this SDK's Qt (ossia/score#2346).
beginExternal()inside a compute pass hitQ_ASSERT(currentTarget)inmaybeRenderTargetData(). A compute pass has no target, so the assertion moves into the render pass branch. Debug builds only; reproduces 3/3 onexamples/3d/voxels.score.QGles2Texture::create()setGL_TEXTURE_MIN_FILTERon multisample textures, raisingGL_INVALID_ENUMfor every MSAA texture (every glTF scene through Qt Quick 3D). It is skipped whensamples > 1.Both apply with
git apply --checkon qtbase3700a2e5with the Gerrit picks fromclone-qt.shand patches 0001–0012 applied. README entries added.🤖 Generated with Claude Code
https://claude.ai/code/session_01JeL19ofVgPe9u9q7J1V9ex