Repository navigation
Conversation
Introduces a cluster.Coordinator interface with two implementations: - EtcdCoordinator (today's embedded etcd server), used whenever clustering is enabled - semantics unchanged - LocalCoordinator, a single-node coordinator with no etcd and no relay listener: the local node is always leader, the cluster is a singleton and assignments-paused flags live in memory. The gin realtime event handler already handles a nil relay, so single-node event paths are unchanged. ColoniesController now depends on Coordinator instead of *EtcdServer. CreateServer/CreateColoniesController gained a clusterEnabled parameter (ServerConfig.ClusterEnabled defaults to enabled for backward compat). CLI: new --cluster flag (default true, COLONIES_CLUSTER env override); --initial-cluster is rejected when clustering is disabled. --dbtype help text no longer mentions the unsupported velocitydb type. Tests: the test harness honors COLONIES_TEST_CLUSTER (default true keeps today's behavior). With COLONIES_TEST_CLUSTER=false the same suites run against the LocalCoordinator: handlers sweep 4m22s -> 2m06s, pkg/fs 22s -> 2.2s, all green. Cluster-specific suites (StartCluster, distributed and exclusive assignment, channel maintenance) always use real etcd. All suites pass in both modes; cluster unit tests cover the LocalCoordinator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a cluster.Coordinator interface with two implementations:
ColoniesController now depends on Coordinator instead of *EtcdServer. CreateServer/CreateColoniesController gained a clusterEnabled parameter (ServerConfig.ClusterEnabled defaults to enabled for backward compat). CLI: new --cluster flag (default true, COLONIES_CLUSTER env override); --initial-cluster is rejected when clustering is disabled. --dbtype help text no longer mentions the unsupported velocitydb type.
Tests: the test harness honors COLONIES_TEST_CLUSTER (default true keeps today's behavior). With COLONIES_TEST_CLUSTER=false the same suites run against the LocalCoordinator: handlers sweep 4m22s -> 2m06s, pkg/fs 22s -> 2.2s, all green. Cluster-specific suites (StartCluster, distributed and exclusive assignment, channel maintenance) always use real etcd.
All suites pass in both modes; cluster unit tests cover the LocalCoordinator.