Skip to content

AO3-7558 Fix 500 error due to pagy overflow in user assignment index #5952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bilka2 wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −5
Open

AO3-7558 Fix 500 error due to pagy overflow in user assignment index #5952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6fb7d5
AO3-7558 Add test for pagy overflow
Bilka2 Jul 28, 2026
9b7353b
AO3-7558 Fix 500 error due to pagy overflow in user assignment index
Bilka2 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions app/views/challenge_assignments/_user_index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,7 @@
<%== pagy_nav @pagy %>

<dl class="assignment index group">

<% @challenge_assignments.each do |assignment| %>
<%= render "assignment_blurb", assignment: assignment %>
<% end %>

<%= render partial: "assignment_blurb", collection: @challenge_assignments, as: :assignment %>
</dl>

<%== pagy_nav @pagy %>
Expand Down
4 changes: 4 additions & 0 deletions features/gift_exchanges/challenge_giftexchange.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,10 @@ Feature: Gift Exchange Challenge
Then I should see "collection_1"
When I follow "2" within ".pagination"
Then I should see "collection_2"
When there are 20 assignments per page
And I reload the page
Then I should see "My Assignments"
But I should not see "collection_2"

Scenario: Mod can approve a posted assignment in a moderated gift exchange
Given everyone has their assignments for "Awesome Gift Exchange"
Expand Down
Loading