Skip to content

AO3-5539 Fix hidden tags functionality for prompts/requests/external works #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
techlingyi wants to merge 7 commits into
base: master
Choose a base branch
from
+24 −2
Open

AO3-5539 Fix hidden tags functionality for prompts/requests/external works #5963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cb1dfa4
AO3-5539 Fix show_hidden warnings/freeforms for requests & external w…
techlingyi Apr 25, 2026
0b715f7
Merge branch 'master' into AO3-5539-show-hidden-tags
techlingyi Apr 30, 2026
cdd6cc4
Merge branch 'master' into AO3-5539-show-hidden-tags
techlingyi May 4, 2026
f63f6e5
AO3-5539 Simplify tags controller show_hidden logic
techlingyi May 5, 2026
77cf1ae
AO3-5539 Add tests for hidden tags on prompts
techlingyi Aug 3, 2026
5a3b5a7
Merge branch 'master' into AO3-5539-show-hidden-tags
techlingyi Aug 3, 2026
7dc666f
AO3-5539 Remove nonfunctional test
techlingyi Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/controllers/tags_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@ def show_hidden
Work
when "chapter"
Chapter
when "request"
Request
when "externalwork"
ExternalWork
end
@display_creation = model.find(params[:creation_id]) if model.is_a? Class

Expand All @@ -114,9 +118,9 @@ def show_hidden
else
@display_tags = case params[:tag_type]
when 'warnings'
@display_creation.archive_warnings
@display_creation.tag_groups["ArchiveWarning"]
when 'freeforms'
@display_creation.freeforms
@display_creation.tag_groups["Freeform"]

@techlingyi techlingyi Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Requests can't have their warnings/freeforms accessed with .archive_warnings or .freeforms, maybe because they're not Taggables? So I decided to just make all objects (except Series) access warnings/freeforms with tag_groups, since it also works for the other types of objects. Let me know if there's performance concerns with this, though!

end
end

Expand Down
18 changes: 18 additions & 0 deletions features/prompt_memes_a/challenge_promptmeme_setup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,24 @@ Feature: Prompt Meme Challenge
In order to have an archive full of works
As a humble user
I want to create a prompt meme and post to it

@javascript
Scenario: Can hide and show additional tags on a prompt

Given I have Battle 12 prompt meme fully set up
Given I am logged in as "myname1"
And I sign up for Battle 12 with combination A
When I am logged in as "myname2"
And I follow "My Preferences"
And I check "Hide additional tags"
And I press "Update"
And I go to "Battle 12" collection's page
And I follow "Prompts (2)"
Then I should see "Show additional tags"
And I should not see "Alternate Universe - Historical"
When I follow "Show additional tags"
Then I should not see "Show additional tags"
And I should see "Alternate Universe - Historical"

Scenario: Can create a collection to house a prompt meme

Expand Down
Loading