AO3-7471 Remove active_record_query_trace, replace w/native - #5975
Open
y7nieSEl5 wants to merge 2 commits into
Open
AO3-7471 Remove active_record_query_trace, replace w/native#5975y7nieSEl5 wants to merge 2 commits into
y7nieSEl5 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7471
Purpose
Removes the overlapping query-source tracing mechanisms and relies on Rails' native verbose query logs.
active_record_query_tracedependencyActiveRecord::LogSubscriberextensionconfig.active_record.verbose_query_logs = truein developmentDevelopment query logs now contain one native
↳ file:lineentry instead of duplicate source information or a multiline gem-generated stack trace.Testing Instructions
Confirm its dependencies are installed:
docker compose exec web bundle checkdocker compose exec web tail -n 30 log/development.logConfirm query entries contain a single Rails-native
↳ file:linesource and do not contain multilineactive_record_query_tracecall stacks or duplicate source lines.Credit
y7nieSEl5, she/her