Repository navigation
feat(dashboard): single Allow split button with duration menu on approval detail - #844
Merged
Merged
Conversation
…oval detail Folds "Allow once", "Allow & Remember" and the expiry clock into one primary split button: the caret picks Once / remember For 1h…30d / Always, the main half runs it. Once resolves `allow`; any other choice resolves `allow_remember` at the "Remember as" scope with that TTL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Authenticated pages hold an SSE stream open, so networkidle never fires and goto times out — the same reason snap.mjs dropped it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Code diff size+264 / −25 across 3 files (net +239)
Source files under |
This was referenced Oct 28, 2026
Merged
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This implements the new Allow control from the Claude Design Approval Queue prototype (
AllowSplitinApprovalDetail.jsx).The approval detail action bar used to have three controls: Allow once, Allow & Remember and the expiry clock (
ExpiryControl). They are now one primary split button:allow. Every other choice resolves withallow_rememberat the scope selected in the "Remember as" dropdown, sending that duration asttl. Always sends nottl.The durations come from the existing
TTL_OPTIONS, so they are all values the API accepts. The design's 8h, 1w and 1y options were left out for that reason.Other changes:
approval/AllowSplit.sveltewith a Storybook story.ExpiryControlis no longer used on the approval page; the profile and agent rule pages still use it.UI_SPEC.md: the split-button and approval-resolution sections now describe the new control.screenshot-approvals.mjs: the expiry-menu shot is replaced by an allow-menu shot plus an "Allow for 24 hours" shot. Its twonetworkidlewaits are nowload: the SSE stream meansnetworkidlenever fires, and the script timed out without this change.The queue rows (✓ / ✕ / ✓✓) are unchanged, as in the design.
Screenshots
Test plan
npm run check(svelte-check): 0 errors, 0 warningsscreenshot-approvals.mjsagainstmake e2e-up: all shots written, including the new menu and 24h selections🤖 Generated with Claude Code