Skip to content

Do not inject LD_LIBRARY_PATH and use RPATH now. #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owent merged 1 commit into from
Jul 28, 2026
Merged

Do not inject LD_LIBRARY_PATH and use RPATH now. #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@ For example, if we want to use the same python3 executable on target and host bu
+ Option(Optional): `PROJECT_THIRD_PARTY_PACKAGE_DIR` : Where to place package sources.
+ Option(Optional): `PROJECT_THIRD_PARTY_INSTALL_DIR` : Where to place installed packages.
+ Option(Optional): `PROJECT_THIRD_PARTY_HOST_INSTALL_DIR` : Where to place installed packages of host system.
+ Option(Optional): `ATFRAMEWORK_CMAKE_TOOLSET_THIRD_PARTY_USE_ABSOLUTE_RPATH` : Use absolute third-party prefix paths
instead of loader-relative paths for additional build `RPATH` entries(default: `OFF`).
+ Option(Optional): `FindConfigurePackageGitFetchDepth` : Fetch depth og git repository.
+ Option(Optional): `ATFRAMEWORK_CMAKE_TOOLSET_THIRD_PARTY_BUILD_DIR` : Where to build packages.
+ Option(Optional): `ATFRAMEWORK_CMAKE_TOOLSET_THIRD_PARTY_HOST_BUILD_DIR` : Where to build packages of host system.
Expand All @@ -240,6 +242,10 @@ For example, if we want to use the same python3 executable on target and host bu
+ Option(Optional): `ATFRAMEWORK_CMAKE_TOOLSET_CLEANUP_BUILD_CACHE` : Cleanup build cache directory after a package is built successfully.
+ Option(Optional): `ATFRAMEWORK_CMAKE_TOOLSET_CLEANUP_PACKAGE_SOURCE_DIR` : Cleanup souce cache directory after a package is built successfully.

cmake-toolset does not modify `LD_LIBRARY_PATH`. Additional build `RPATH` entries use `$ORIGIN` on Unix or
`@loader_path` on Apple by default; set `ATFRAMEWORK_CMAKE_TOOLSET_THIRD_PARTY_USE_ABSOLUTE_RPATH=ON` to use absolute
third-party prefix paths instead. Windows DLL lookup continues to use `PATH`.
Comment on lines +245 to +247

```cmake
# set(PROJECT_THIRD_PARTY_PACKAGE_DIR "${PROJECT_SOURCE_DIR}/third_party/packages")
# set(PROJECT_THIRD_PARTY_INSTALL_DIR "${PROJECT_SOURCE_DIR}/third_party/install/${CMAKE_SYSTEM_NAME}-${CMAKE_SYSTEM_PROCESSOR}-${CMAKE_CXX_COMPILER_ID}")
Expand Down
28 changes: 1 addition & 27 deletions ci/do_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
cd "$(cd "$(dirname $0)" && pwd)/.."

set -ex
unset LD_LIBRARY_PATH

export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8
Expand Down Expand Up @@ -61,8 +62,6 @@ elif [[ "$1" == "gcc.no-rtti.test" ]]; then
exit $CMAKE_CONFIGURE_EXIT_CODE
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
ctest . -V
elif [[ "$1" == "gcc.no-exceptions.test" ]]; then
echo "$1"
Expand All @@ -79,8 +78,6 @@ elif [[ "$1" == "gcc.no-exceptions.test" ]]; then
exit $CMAKE_CONFIGURE_EXIT_CODE
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
ctest . -V
elif [[ "$1" == "gcc.static.test" ]]; then
echo "$1"
Expand All @@ -97,8 +94,6 @@ elif [[ "$1" == "gcc.static.test" ]]; then
exit $CMAKE_CONFIGURE_EXIT_CODE
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
ctest . -V
elif [[ "$1" == "gcc.shared.test" ]]; then
echo "$1"
Expand All @@ -115,8 +110,6 @@ elif [[ "$1" == "gcc.shared.test" ]]; then
exit $CMAKE_CONFIGURE_EXIT_CODE
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
ctest . -V
elif [[ "$1" == "gcc.libressl.test" ]]; then
echo "$1"
Expand All @@ -133,8 +126,6 @@ elif [[ "$1" == "gcc.libressl.test" ]]; then
exit $CMAKE_CONFIGURE_EXIT_CODE
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
ctest . -V
elif [[ "$1" == "gcc.boringssl.test" ]]; then
echo "$1"
Expand All @@ -151,8 +142,6 @@ elif [[ "$1" == "gcc.boringssl.test" ]]; then
exit $CMAKE_CONFIGURE_EXIT_CODE
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
ctest . -V
elif [[ "$1" == "gcc.mbedtls.test" ]]; then
echo "$1"
Expand All @@ -169,8 +158,6 @@ elif [[ "$1" == "gcc.mbedtls.test" ]]; then
exit $CMAKE_CONFIGURE_EXIT_CODE
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
ctest . -V
elif [[ "$1" == "gcc.4.8.test" ]]; then
echo "$1"
Expand All @@ -187,8 +174,6 @@ elif [[ "$1" == "gcc.4.8.test" ]]; then
exit $CMAKE_CONFIGURE_EXIT_CODE
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
ctest . -V
elif [[ "$1" == "gcc.standalone-upb.test" ]]; then
echo "$1"
Expand All @@ -205,7 +190,6 @@ elif [[ "$1" == "gcc.standalone-upb.test" ]]; then
exit $CMAKE_CONFIGURE_EXIT_CODE
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/third_party/install/*)
elif [[ "$1" == "clang.test" ]]; then
echo "$1"
mkdir -p test/build_jobs_dir
Expand Down Expand Up @@ -245,8 +229,6 @@ elif [[ "$1" == "clang.test" ]]; then
exit $CMAKE_CONFIGURE_EXIT_CODE
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
ctest . -V
elif [[ "$1" == "gcc.vcpkg.test" ]]; then
echo "$1"
Expand All @@ -272,8 +254,6 @@ elif [[ "$1" == "gcc.vcpkg.test" ]]; then
exit $CMAKE_CONFIGURE_EXIT_CODE
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
ctest . -V
elif [[ "$1" == "msys2.mingw.static.test" ]]; then
echo "$1"
Expand All @@ -298,7 +278,6 @@ elif [[ "$1" == "msys2.mingw.static.test" ]]; then
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
export PATH="$PATH:$THIRD_PARTY_PREBUILT_DIR/bin"
ctest . -V
elif [[ "$1" == "msys2.mingw.shared.test" ]]; then
Expand All @@ -325,7 +304,6 @@ elif [[ "$1" == "msys2.mingw.shared.test" ]]; then
fi
cmake --build . -j || cmake --build . || cmake --build . --verbose
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
export PATH="$PATH:$THIRD_PARTY_PREBUILT_DIR/bin"
ctest . -V
elif [[ "$1" == "msvc.static.test" ]]; then
Expand Down Expand Up @@ -353,7 +331,6 @@ elif [[ "$1" == "msvc.static.test" ]]; then
fi
cmake --build . -j --config $CI_BUILD_CONFIGURE_TYPE || cmake --build . --config $CI_BUILD_CONFIGURE_TYPE
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
export PATH="$PATH:$THIRD_PARTY_PREBUILT_DIR/bin"
ctest . -V -C $CI_BUILD_CONFIGURE_TYPE
elif [[ "$1" == "msvc.shared.test" ]]; then
Expand Down Expand Up @@ -381,7 +358,6 @@ elif [[ "$1" == "msvc.shared.test" ]]; then
fi
cmake --build . -j --config $CI_BUILD_CONFIGURE_TYPE || cmake --build . --config $CI_BUILD_CONFIGURE_TYPE
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
export PATH="$PATH:$THIRD_PARTY_PREBUILT_DIR/bin"
ctest . -V
elif [[ "$1" == "msvc.vcpkg.test" ]]; then
Expand Down Expand Up @@ -419,7 +395,6 @@ elif [[ "$1" == "msvc.vcpkg.test" ]]; then
fi
cmake --build . -j --config $CI_BUILD_CONFIGURE_TYPE || cmake --build . --config $CI_BUILD_CONFIGURE_TYPE
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
export PATH="$PATH:$THIRD_PARTY_PREBUILT_DIR/bin"
ctest . -V -C $CI_BUILD_CONFIGURE_TYPE
elif [[ "$1" == "msvc2017.test" ]]; then
Expand All @@ -439,7 +414,6 @@ elif [[ "$1" == "msvc2017.test" ]]; then
fi
cmake --build . -j --config $CI_BUILD_CONFIGURE_TYPE || cmake --build . --config $CI_BUILD_CONFIGURE_TYPE
THIRD_PARTY_PREBUILT_DIR=$(ls -d $PWD/../third_party/install/*)
export LD_LIBRARY_PATH="$THIRD_PARTY_PREBUILT_DIR/lib64:$THIRD_PARTY_PREBUILT_DIR/lib"
export PATH="$PATH:$THIRD_PARTY_PREBUILT_DIR/bin"
ctest . -V -C $CI_BUILD_CONFIGURE_TYPE
elif [[ "$1" == "android.arm64.test" ]]; then
Expand Down
Loading