Skip to content

Update ports - #140

Merged
owent merged 6 commits into
mainfrom
dev
Sep 17, 2026
Merged

owent merged 6 commits into
mainfrom
dev

Conversation

@owent

@owent owent commented Sep 15, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI lite review requested due to automatic review settings September 15, 2026 07:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

There are confirmed build/compatibility issues in the new opentelemetry-cpp patch and an inconsistent version comparison in the opentelemetry port logic that should be corrected before merging.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR updates multiple third-party port versions in cmake-toolset and adjusts patch/build-option handling to keep builds consistent across platforms (notably Windows TLS backends and upstream CMake option changes).

Changes:

  • Bump a set of port default versions (libwebsockets, opentelemetry-cpp, gtest, OpenSSL, curl, grpc, ngtcp2/nghttp2/nghttp3, mimalloc, lua, snappy, etc.).
  • Add/update upstream patch files to preserve toolset compatibility (CMake minimums, link checks, warning flags, legacy compiler workarounds).
  • Adjust port build options for upstream default behavior changes (e.g., libwebsockets HTTP/3 + Windows TLS backend).
File summaries
File Description
ports/web/libwebsockets.cmake Bumps libwebsockets default to v5.0.0 and adds build options to disable SChannel/HTTP3 defaults.
ports/web/libwebsockets-v5.0.0.patch New patch to align upstream CMake behavior (min version, include ordering, OpenSSL/libuv checks).
ports/test/gtest.cmake Bumps gtest default version to v1.18.0.
ports/telemetry/opentelemetry-cpp.cmake Bumps opentelemetry-cpp to v1.29.0 and adapts to renamed CMake option namespace.
ports/telemetry/opentelemetry-cpp-v1.29.patch New patch for opentelemetry-cpp v1.29 (GCC 4.8 compatibility + type_traits tweak).
ports/ssl/openssl/openssl.cmake Bumps OpenSSL version from 3.5.7 to 3.5.8.
ports/redis/hiredis.cmake Bumps hiredis version from v1.4.0 to v1.4.1.
ports/ngtcp2/ngtcp2.cmake Bumps ngtcp2 version from v1.24.0 to v1.25.0.
ports/ngtcp2/ngtcp2-v1.25.patch New patch for ngtcp2 v1.25 (library suffix + example subdir behavior).
ports/ngtcp2/nghttp3.cmake Bumps nghttp3 version from v1.17.0 to v1.18.0.
ports/nghttp2/nghttp2.cmake Bumps nghttp2 version from v1.69.0 to v1.70.0.
ports/nghttp2/nghttp2-v1.70.patch New patch for nghttp2 v1.70 (Windows link check libs).
ports/malloc/mimalloc.cmake Bumps mimalloc default version from v3.4.1 to v3.5.2.
ports/malloc/mimalloc-v3.5.patch New patch for mimalloc v3.5 (C++ new_handler and Apple environ handling).
ports/lua/lua.cmake Bumps lua version from v5.5.0 to v5.5.1.
ports/libcurl/libcurl.cmake Bumps libcurl default version from 8.21.0 to 8.22.0.
ports/libcurl/libcurl-8.22.patch New patch for curl 8.22 (OpenSSL check link requirements + SSL libs reorder).
ports/gsl/ms-gsl.cmake Bumps Microsoft.GSL version from v4.2.2 to v5.0.0.
ports/gsl/gsl-lite.cmake Bumps gsl-lite version from v1.1.0 to v1.1.1.
ports/grpc/grpc.cmake Bumps grpc version from v1.82.1 to v1.84.0 (for modern toolchains).
ports/grpc/grpc-v1.84.patch New patch for grpc v1.84 (explicit std::string conversions in generators/core).
ports/compression/snappy.cmake Bumps snappy version from 1.2.2 to 1.3.0.
ports/compression/snappy-1.3.patch New patch for snappy 1.3 (avoid -Werror and inline attribute issues).
.gitignore Ignores /test/.cmake-toolset directory.
Review details
  • Files reviewed: 23/24 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +12 to +13
+#include <memory>
+namespace std
list(APPEND ATFRAMEWORK_CMAKE_TOOLSET_THIRD_PARTY_OPENTELEMETRY_CPP_BUILD_OPTIONS
"-D${ATFRAMEWORK_CMAKE_TOOLSET_THIRD_PARTY_OPENTELEMETRY_CPP_OPTION_PREFIX}STL=OFF")
endif()
if(ATFRAMEWORK_CMAKE_TOOLSET_THIRD_PARTY_OPENTELEMETRY_CPP_VERSION VERSION_LESS "1.21.0")
@owent
owent merged commit 88d4afe into main Sep 17, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants