Skip to content

Dev - #59

Merged
owent merged 5 commits into
v2from
dev
Sep 15, 2026
Merged

Dev#59
owent merged 5 commits into
v2from
dev

Conversation

@owent

@owent owent commented Sep 15, 2026 •

Copy link
Copy Markdown
Owner

Fixes #60

Copilot AI lite review requested due to automatic review settings September 15, 2026 07:34
bash ci/do_ci.sh coverage ;
- name: Uploaded code coverage
uses: codecov/codecov-action@v5
uses: codecov/codecov-action@v7

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflows reference GitHub Actions major versions that appear to be invalid/nonexistent (e.g., actions/cache@v6, actions/stale@v11, codecov/codecov-action@v7), which would break CI.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR updates coroutine caller management to resume multiple waiters in registration (FIFO) order (instead of hash iteration order), aligning behavior between the C++20 coroutine backend and the stackful channel backend and making wake-up order deterministic.

Changes:

  • Replace unordered multi-caller storage with an order-preserving container (list + hash index) for FIFO resume order.
  • Add unit tests that assert FIFO wake-up ordering for both task futures and stackful channels.
  • Update documentation dependencies and refresh GitHub Actions workflow versions.
File summaries
File Description
test/case/task_promise_test.cpp Adds a FIFO-order test for multiple callers awaiting the same task future.
test/case/coroutine_context_channel_test.cpp Adds FIFO-order tests for multiple callers on stackful channel contexts (including dedup and requeue).
src/libcopp/coroutine/std_coroutine_common.cpp Switches promise caller manager multi-caller operations to the FIFO container.
src/libcopp/coroutine/stackful_channel.cpp Switches stackful channel context multi-caller operations to the FIFO container.
include/libcopp/coroutine/std_coroutine_common.h Introduces FIFO multi-caller container (list + unordered_map index) for promise caller manager.
include/libcopp/coroutine/stackful_channel.h Introduces FIFO multi-caller container (list + unordered_map index) for stackful channel context base.
docs/requirements.txt Bumps MkDocs-related documentation dependency minimum versions.
CHANGELOG.md Documents the FIFO wake-up semantic change and dependency updates for 2.3.3.
.github/workflows/sync.yml Updates checkout action major version.
.github/workflows/stale.yml Updates stale action major version (currently to an invalid major).
.github/workflows/main.yml Updates multiple action majors, fixes a cache key expression, but includes invalid action majors.
Review details
  • Files reviewed: 11/11 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

handle_delegate unique_caller_;
// Mostly, there is only one caller for a promise, we needn't hash map to store one handle
std::unique_ptr<multi_caller_set> multiple_callers_;
// Mostly, there is only one caller for a promise, we needn't container to store one handle
handle_delegate unique_caller_;
// Mostly, there is only one caller for a promise, we needn't hash map to store one handle
std::unique_ptr<multi_caller_set> multiple_callers_;
// Mostly, there is only one caller for a promise, we needn't container to store one handle
@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.51%. Comparing base (0d6104e) to head (5415988).
⚠️ Report is 5 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2      #59      +/-   ##
==========================================
+ Coverage   89.62%   90.51%   +0.89%     
==========================================
  Files          44       44              
  Lines        3094     3132      +38     
  Branches      386      392       +6     
==========================================
+ Hits         2773     2835      +62     
+ Misses        321      297      -24     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atframework-aicr

atframework-aicr Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

AI Code Review

Updated: 2026-09-15 10:52:10 UTC | Commit: 7307ec1

AI Code Review Summary

Target: Dev
Author: @atframework-aicr[bot]
Branch: dev
Reviewers: @atframework-aicr[bot]


No summary provided.

Problems (1)

# Severity Category Location Message
0 LOW correctness CHANGELOG.md:3 本次变更在 CHANGELOG.md 新增 ## 2.3.3 版本条目,但 CMakeLists.txt 第 27 行的 project(... VERSION "2.3.2") 未同步升级。该仓库既有惯例是同一提交内同时修改两处(经 git 历史核实:2.3.0 于 04486f5、2.3.1 于 5642a6e、2.3.2 于 e76d9b6 均为同提交成对变更)。若按此分支发布 2.3.3,生成的 libcopp_build_features.h 中 LIBCOPP_VERSION、安装/包管理元数据仍报告 2.3.2,下游 find_package(libcopp 2.3.3) 等版本检查会失败。最小修复:将 CMakeLists.txt 的 VERSION 提升为 2.3.3。

Code reference: CHANGELOG.md:3

# CHANGELOG

## 2.3.3

1. Resume multiple callers of `promise_caller_manager` (C++20 coroutine) and `stackful_channel_context_base`

  • Powered by AICodeReviewer*

Open Issues (2)

1. [LOW] correctness — CHANGELOG.md:3 (new in 7307ec1)
2. [LOW] correctness — src/libcopp/coroutine/std_coroutine_common.cpp:58-61 (resolution not confirmed)

@owent
owent merged commit 5415988 into v2 Sep 15, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AICR] [LOW] 2 problems · 在 LIBCOPP MACRO ENABLE STD VARIANT

3 participants