Skip to content

Fix for rfd comment permissions - #295

Merged
notpeter merged 1 commit into
mainfrom
comments_permissions
Oct 23, 2026
Merged

notpeter merged 1 commit into
mainfrom
comments_permissions

Conversation

@notpeter

@notpeter notpeter commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RFD comments are currently implemented just-in-time on the vercel side but this was incorrectly ensuring that the user had permissions using the wrong numeric ID. It was using pullRequest and not rfdNumber.

@vercel

vercel Bot commented Oct 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
rfd-site Ready Ready Preview Oct 23, 2026 3:29pm UTC

Request Review

@notpeter
notpeter requested a review from augustuswm October 23, 2026 15:29
@notpeter
notpeter merged commit ce56d1a into main Oct 23, 2026
7 checks passed
@notpeter
notpeter deleted the comments_permissions branch October 23, 2026 15:38

This branch was successfully deployed

1 active deployment
Preview — 6ab0bff7 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants