testocache: harden persistent cache and add namespaces#26
Open
dmedovich wants to merge 3 commits into
Open
Conversation
metafates
requested changes
Jul 16, 2026
| // Namespaces are isolated from each other and from the package-level cache | ||
| // functions. Namespace names must follow the same validity rules as cache keys. | ||
| func Namespace(name string) Cache { | ||
| return Cache{namespace: name, scoped: true} |
Member
There was a problem hiding this comment.
I think non-empty namespace already means scoped cache, so we can omit scoped field and just check that namespace != "" instead
or maybe let's just make it a method
func (c Cache) scoped() bool {
return c.namespace != ""
}| func hash(key string) (string, error) { | ||
| h := fnv.New64a() | ||
| func validatePattern(pattern string) error { | ||
| if err := validate(pattern); err != nil { |
Member
There was a problem hiding this comment.
since we have two validate functions now, let's rename validate to validateKey to make it more obvious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Closes #25
This PR hardens the file-backed cache behavior and adds scoped cache namespaces for plugins sharing the
same cache directory.
Changes
os.Rename;Keys;.gitignore;ErrNotFoundconsistently for missing entries;testocache.Namespacefor isolated keyspaces;The existing package-level API and FNV-based cache filenames remain compatible.
Testing
go test ./...go test -race ./testocachegolangci-lint run --tests=false --timeout=5mgit diff --check