Skip to content

fix: wave 2 typecheck — renderer signature admits hostId #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pacphi merged 1 commit into from
Aug 15, 2026
Merged

fix: wave 2 typecheck — renderer signature admits hostId #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/commands/status.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,10 @@ const row = (subsystem, level, message, fix = null) => ({ subsystem, level, mess
// lib/opencode.mjs, never in the dispatch loop itself. Adding a fourth host
// means adding (or not adding) a table entry here — the loop that walks this
// table never changes.
async function opencodeDetailRows({ cfg, pkgRoot, facts }) {
// The loop also passes `hostId`; this renderer doesn't need it (it IS the
// opencode renderer) but the signature admits it so the dispatch call site
// typechecks for every renderer uniformly.
async function opencodeDetailRows({ cfg, pkgRoot, facts, hostId: _hostId = 'opencode' } = /** @type {any} */ ({})) {
const rows = [];
try {
if (!facts.hosts?.opencode?.present) {
Expand Down
Loading