fix(vfs): keep macOS watcher setup from blocking readiness - #343
Merged
Conversation
|
Docs preview: https://vide.pascal-lab.net/preview/pr-343/ |
hongjr03
force-pushed
the
fix/watcher-rediness
branch
from
August 14, 2026 07:15
de18dd8 to
9c9f825
Compare
hongjr03
marked this pull request as ready for review
August 14, 2026 07:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PollWatcheron macOS so FSEvents run-loop startup/shutdown cannot block VFS loadingRoot cause
The failing diagnostics and reload tests were waiting for VFS
Progress(Finished). The macOSnotifyFSEvents backend could block while registering a watched directory before that message was emitted, leaving workspace readiness permanently false. Reducing Rust test concurrency changed the timing but did not remove that blocking path.Validation
cargo fmt --all -- --checkcargo xtask check-config-artifactscargo clippy --workspace --all-targets -- -D warningscargo test --workspacecargo test -p vide --lib: 150 passed, 0 failedThe VFS regression test also records its event journal on timeout and verifies duplicate roots are registered once before loading completes.