Repository navigation
Does ubuntu-latest image need a build dependency installation step #1003
Description
I added a few sudo commands in our generate_bindings.sh script file in our python in an attempt to simplify the workflow file in 363d2b5 not really considering that this script is not only being run by a github runner but rather should also be run on local dev machines as well.
Should we return this step back to the workflow for our ubuntu-latest runner image?
- name: "Install build dependencies"
run: |
sudo apt update
sudo apt install -y build-essential python3-dev
363d2b5#diff-092659a9bd0068791326fb1d08f005532e5aeb983b999a7bd32c51deee0a71d5L40-L43
It clearly is not preventing workflows from failing following its removal in #1000. I am curious if someone has some insight on its purpose at all? I see that it looks like it may have simply appeared when we pulled ffi into the monorepo in cd3ad47
cd3ad47#diff-815ba4bb400db19ee2163135e803799582cec49b3a88fdc1855c583a8af83344R37-R40
Activity
[-]Does ubuntu-latest image need a[/-][+]Does ubuntu-latest image need a build dependency installation step[/+]DanGould commentedon Aug 27, 2025
yes
spacebear21 commentedon Aug 27, 2025
I don't see why ubuntu-latest runners even need this, since python CI is passing currently? Just removing those entirely seems fine.
benalleng commentedon Aug 27, 2025
Ok, I have this branch If we want it, fd63fca
Here is the ubuntu-latest runner readme,
build-essentialsandpython3-devare not baked in but its possible we were using them in the past but aren't anymore?