Repository navigation
cargo test -p payjoin fails #1019
Description
8ceccaa broke test builds with the default features:
error[E0432]: unresolved import `crate::send::v1`
--> payjoin/src/core/send/v2/session.rs:108:22
|
108 | use crate::send::v1::SenderBuilder;
| ^^ could not find `v1` in `send`
|
Activity
nothingmuch commentedon Aug 29, 2025
cc @DanGould
DanGould commentedon Aug 29, 2025
The session tests must not use v1::SenderBuilder. Use v2 with NoOp persister.
DanGould commentedon Aug 29, 2025
I wonder why this isn't tested by CI
nothingmuch commentedon Aug 29, 2025
because
payjoin/contrib/test.shonly tests with --all-featuresbenalleng commentedon Sep 2, 2025
Going to take this and look into adding a test suite that doesn't use
--all-featuresbenalleng commentedon Oct 29, 2025
The exact error linked #1019 (comment) has actually been resolved as of d6ab28d however several other errors still exist when running
cargo test -p payjoinArowolokehinde commentedon Mar 20, 2026
hi @DanGould and @nothingmuch @benalleng has this issue been resolved ?
i would like to take a look at the other errors
benalleng commentedon Mar 24, 2026
I believe that #1036 should really close this, feel free to give that PR a test, as for other issues, take a look at maybe some more recent ones and just start asking questions!