Repository navigation
SessionHistory should always have one element #1046
Description
Several public session history methods currently mistakenly return Option<T> because replaying a SEL with no events is valid, leaving the session in an Uninitialized state. PR #1014 removes the Uninitialized variant and enforces that every SEL must contain at least one event. After we remove the Unintialized state, we can remove the optional return type of session history methods that read from the first event. e.g fallback_tx and pj_param for the sender and session_context() & pj_uri() for the receiver.
Reacted by Yuval Kogman
Activity
0xZaddyy commentedon Sep 8, 2025
Hi @arminsabouri
i'm working on this already
arminsabouri commentedon Sep 8, 2025
Thank you for picking this up. Just a heads up. I'd like to get #1014 in first. So please try to either build on top of those commits or rebase when we finish revewing and merging that work.
0xZaddyy commentedon Sep 9, 2025
Alright then!
arminsabouri commentedon Sep 11, 2025
Reopening. There are follow up items from the PR above #1055 (review)
arminsabouri commentedon Sep 11, 2025
Closed by #1062