You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
payjoin/src/core/send/v2/session.rs:82:9: replace SessionHistory::terminal_error -> Option<String> with None
payjoin/src/core/send/v2/session.rs:83:13: delete match arm SessionEvent::SessionInvalid(error) in SessionHistory::terminal_error
Running cargo mutants version: cargo-mutants 25.2.2
For the complete list, please check the mutants.out artifact.
After #1107 do we need terminal_error on the sender side at all? all of our error states in replay_event_log return an InternalReplayError and not a ReceiveSession::TerminalFailure as was possible before
/// TODO: This should replay the event log and return the actual error, not a JSON reply
but you're right that it doesn't even make sense since you'd need to replay the log in the first place to get a SessionHistory object. I think terminal_error was only necessary for responding to senders, which #1060 moves into the state machine anyway.
Activity
benalleng commentedon Sep 29, 2025
After #1107 do we need
terminal_erroron the sender side at all? all of our error states inreplay_event_logreturn anInternalReplayErrorand not aReceiveSession::TerminalFailureas was possible beforespacebear21 commentedon Sep 29, 2025
I left this todo on terminal_error in #1060:
but you're right that it doesn't even make sense since you'd need to replay the log in the first place to get a SessionHistory object. I think
terminal_errorwas only necessary for responding to senders, which #1060 moves into the state machine anyway.arminsabouri commentedon Oct 3, 2025
Dup of #1123
benalleng commentedon Oct 3, 2025
this is the issue