Skip to content

New Mutants Found #1118

Closed
Closed

Description

@github-actions

Displaying up to the first 15 missed mutants:

payjoin/src/core/send/v2/session.rs:82:9: replace SessionHistory::terminal_error -> Option<String> with None
payjoin/src/core/send/v2/session.rs:83:13: delete match arm SessionEvent::SessionInvalid(error) in SessionHistory::terminal_error

Running cargo mutants version: cargo-mutants 25.2.2
For the complete list, please check the mutants.out artifact.

Activity

  1. benalleng commented on Sep 29, 2025

    @benalleng
    Collaborator

    After #1107 do we need terminal_error on the sender side at all? all of our error states in replay_event_log return an InternalReplayError and not a ReceiveSession::TerminalFailure as was possible before

  2. spacebear21 commented on Sep 29, 2025

    @spacebear21
    Collaborator

    I left this todo on terminal_error in #1060:

    /// TODO: This should replay the event log and return the actual error, not a JSON reply

    but you're right that it doesn't even make sense since you'd need to replay the log in the first place to get a SessionHistory object. I think terminal_error was only necessary for responding to senders, which #1060 moves into the state machine anyway.

  3. added this to the payjoin-1.0 milestone on Sep 29, 2025
  4. arminsabouri commented on Oct 3, 2025

    @arminsabouri
    Contributor

    Dup of #1123

  5. benalleng commented on Oct 3, 2025

    @benalleng
    Collaborator

    this is the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions