Audit Sender SessionEvents

The sender session events should follow the same logic as the receiver events, namely:

@zealsham

@zealsham will start by renaming the sender session events

@benalleng

@benalleng Will pick up adding a closed variant for the sender

@arminsabouri

@arminsabouri Will take audit the sender session events for primary info

What sender state transition would it be appropriate to actually present this SessionEvent::Closed for

What sender state transition would it be appropriate to actually present this SessionEvent::Closed for

Any case where we have to fatally or successfully close the session

@arminsabouri

@arminsabouri correct me if I'm wrong but I think SessionEvent::Closed with a failure outcome could essentially replace SessionEvent::SessionInvalid for the sender?

@arminsabouri correct me if I'm wrong but I think SessionEvent::Closed with a failure outcome could essentially replace SessionEvent::SessionInvalid for the sender?

Yes. I agree. both SessionInvalid and ProposalReceived indicate a session is closed and we can reconcile them into one explicit "closed" event.

Cross posting from #1125 :

For maximum consistency with the Receiver events, ultimately I'd like to see:

pub enum SessionEvent {
    /// Sender was created with a HPKE key pair
    Created(WithReplyKey),
    /// Sender POSTed the Original PSBT, and is waiting to receive a Proposal PSBT
    PostedOriginalPsbt(),
    /// Sender received a Proposal PSBT
    RetrievedProposalPsbt(bitcoin::Psbt),
    /// Closed session
    Closed(SessionOutcome),
}

closed by #1125

Navigation Menu

Repository navigation

Audit Sender SessionEvents #1119

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Audit Sender SessionEvents #1119

Description

Activity

arminsabouri commented on Sep 29, 2025

arminsabouri commented on Sep 29, 2025

arminsabouri commented on Sep 29, 2025

benalleng commented on Sep 30, 2025

arminsabouri commented on Oct 1, 2025

spacebear21 commented on Oct 1, 2025

arminsabouri commented on Oct 1, 2025

spacebear21 commented on Oct 1, 2025

spacebear21 commented on Oct 3, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions