Repository navigation
Is FallbackBroadcasted session outcome variant necessary? #1138
Description
I'm not sure that this new variant is necessary, wouldn't a Failure or Cancel be appropriate?
Originally posted by @spacebear21 in #1061 (comment)
I'm not sure that this new variant is necessary, wouldn't a Failure or Cancel be appropriate?
Originally posted by @spacebear21 in #1061 (comment)
Activity
zealsham commentedon Dec 8, 2025
I think it's a choice of explicity stating that a fallback TX was broadcasted vs implicitly assuming that it was. For the failure/cancel events, depending on the reason of failure/cancel fallback TX can be broadcasted, while adding fallbackbroadcasted event basically tell that the sessionevent transitioned to a state where the fallback tx was definitely broadcasted.
[-]Is FallbackBroadcasted session event variant necessary?[/-][+]Is FallbackBroadcasted session outcome variant necessary?[/+]DanGould commentedon Apr 22, 2026
@spacebear21 is this closed by #1496 and #1470
DanGould commentedon Apr 25, 2026
I'm going to guess it is
spacebear21 commentedon Apr 27, 2026
The distinction between the FallbackBroadcasted and Cancel variants is that the former is always sender-initiated and the latter is always receiver-initiated. Perhaps the names could be clearer, or at last this distinction should be clear in doc strings.