Does the payjoin-cli cancel have the correct semantics? #1605

Activity

1. benalleng

   added

   payjoin-cli

   on Jun 5, 2026
2. benalleng commented on Jun 5, 2026

   

   benalleng

   on Jun 5, 2026

   CollaboratorAuthor

   More actions

   Just to additionally weigh in here I do think its important to keep in mind that the payjoin-cli commands are payjoin focused so that a bare cargo run cancel will simply not proceed the payjoin but the transaction can still proceed whereas cargo run cancel --no-broadcast is a special case beyond just cancelling the payjoin.
3. DanGould

   added this to the payjoin-cli-1.0 milestone on Jun 8, 2026
4. spacebear21 commented on Jun 17, 2026

   

   spacebear21

   on Jun 17, 2026

   Collaborator

   More actions

   What's weird here is after cancel payjoin-cli has no way to broadcast a transaction by replaying until the PendingFallback state. I think we want there to be a way to broadcast the fallback on a closed session

   Would it be sufficient to add a way to retrieve the raw fallback transaction so that it can be broadcasted with e.g. bitcoin-cli sendrawtransaction? Perhaps in payjoin-cli history output or similar. For example on failure closes we simply print:

   println!("Payjoin failed. To broadcast the fallback transaction, run:");
   println!(
       "  bitcoin-cli -rpcwallet=<wallet> sendrawtransaction {:#}",
5. benalleng commented on Jun 22, 2026

   

   benalleng

   on Jun 22, 2026

   CollaboratorAuthor

   More actions

   I'm a bit confused looking at the cli which session state you are hoping to add this additional information at. Would we want this print to go alongside the print here?
   

   rust-payjoin/payjoin-cli/src/app/v2/mod.rs

   Lines 679 to 684 in dac9c9b

   	SendSession::PendingFallback(_) => {
   	let id = persister.session_id();
   	println!(
   	"Session {id} was cancelled. Run `payjoin-cli cancel {id}` to cancel and broadcast the fallback transaction."
   	);
   	return Ok(());

   
   and for the receiver
   

   rust-payjoin/payjoin-cli/src/app/v2/mod.rs

   Lines 791 to 796 in dac9c9b

   	ReceiveSession::PendingFallback(_) => {
   	let id = persister.session_id();
   	println!(
   	"Session {id} was cancelled. Run `payjoin-cli cancel {id}` to cancel and broadcast the fallback transaction."
   	);
   	return Ok(());

   
   Or should this be instead of the cancel suggestion?
6. bc1cindy commented on Jun 24, 2026

   

   bc1cindy

   on Jun 24, 2026

   Contributor

   More actions

   concept ACK
7. benalleng

   closed this as completedin #1673on Jun 24, 2026