You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Should OhttpDecapsulation or Hpke Errors be considered fatal #1844
At the moment it seems like OhttpDecapsulation errors and Hpke errors are considered fatal but in looking closer at them in #1843 I think that they can be transient but I would like some more brains on this.
At the moment it seems like OhttpDecapsulation errors and Hpke errors are considered fatal but in looking closer at them in #1843 I think that they can be transient but I would like some more brains on this.
Transient ussually implies you can wait or change some config (relay url for example) and expect a different result. Maybe somethings have change since I last looked at this code but I don't think that applies to either error type.
I think you are right here, the only other case would be some network error causing the contents being sent incomplete but either way it seems like perhaps the safest option here would be to consider it fatal.
Activity
benalleng commentedon Aug 25, 2026
I have since dropped these changes from the PR as I figure we should answer this question first before making the change
arminsabouri commentedon Sep 2, 2026
Transient ussually implies you can wait or change some config (relay url for example) and expect a different result. Maybe somethings have change since I last looked at this code but I don't think that applies to either error type.
benalleng commentedon Sep 4, 2026
I think you are right here, the only other case would be some network error causing the contents being sent incomplete but either way it seems like perhaps the safest option here would be to consider it fatal.