Consider renaming FFi InputPairError::InvalidTransaction #1974

Activity

1. benalleng

   added

   ffi

   on Oct 13, 2026
2. Christopherdominic commented on Oct 19, 2026

   

   Christopherdominic

   on Oct 19, 2026 – with ChatGPT Codex Connector

   Contributor

   More actions

   @benalleng I'd like to work on this. My proposed change is to rename the FFI InputPairError::InvalidTransaction(String) variant to TransactionDecode(String), as suggested in the issue, so callers can distinguish failure to consensus-decode transaction bytes from later PSBT input validation.

   I'd update the enum and its documentation in payjoin-ffi/src/receive/error.rs, the transaction-decoding error mapping in payjoin-ffi/src/receive/mod.rs, and any affected binding tests/examples. I'd retain the decoder's error detail and make the display message describe the decode failure. I'd add regression coverage showing malformed transaction bytes produce TransactionDecode, while an existing valid-transaction input still follows the normal validation path, then run the FFI tests, binding generation checks, formatting, Clippy, and spelling checks. I'd record the public error-variant rename in payjoin-ffi/CHANGELOG.md.

   This changes a public binding error name. Are you happy with a direct rename for the next bindings release, or do you want a compatibility transition? Please confirm the naming and compatibility approach before I implement it.

   AI disclosure: This comment was drafted with OpenAI Codex assistance.