Repository navigation
Audit payjoin-ffi's ImplementationError From implementation #737
Description
We need to make sure our error conversions are sane so that arbitrary types don't get converted into unrelated errors accidentally.
In payjoin-ffi, currently any arbitrary String can be converted to an ImplementationError. Maybe we should just use anyhow::Error?
See discussion in LtbLightning/payjoin-ffi#71 (comment)
Activity
spacebear21 commentedon Jun 6, 2025
Related issue: #751
feat: wrap bitcoin_uri::de::Error in PayjoinUriError type
arminsabouri commentedon Sep 8, 2025
@spacebear21
isshould this be 1.0 milestone issue?spacebear21 commentedon Sep 8, 2025
Hmm, it only touches payjoin-ffi and downstream so technically we could release a payjoin-1.0 before this is done. But for any dart/python 1.0 release I think this is necessary.
arminsabouri commentedon Sep 8, 2025
cc @chavic
arminsabouri commentedon Sep 8, 2025
TODO: assign chavic to this ticket
spacebear21 commentedon Sep 26, 2025
Closed by #1029