Repository navigation
Evaluate making ImplementationError an actual type #751
Description
Making me wonder if our
pub type ImplementationError = Box<dyn error::Error + Send + Sync>;type alias can be std::error::Error and 'static if we make it our own type instead, and if that would solve some problems with ffi expecting to deal with std::error::Error types
Activity
feat: wrap bitcoin_uri::de::Error in PayjoinUriError type
spacebear21 commentedon Jul 21, 2025
Partially addressed by #768 - I think the callsites of ImplementationError in FFI can now be updated to use a boxed error instead of downcasting to a string, then the ugly
impl From<String> for ImplementationErrorhack may be removed.spacebear21 commentedon Sep 26, 2025
Closed by #1029