Skip to content

Run ./contrib/test.sh on OSX (and Windows?) in github actions #877

Closed

Description

@nothingmuch

For context, I introduced a dependency on flock which it turns out is not a standard POSIX shell command (#878), thereby breaking the test script on Dan's machine

To ensure tooling continues to work for all contributors, we should consider running at least a
minimal selection of tests on non-Linux platforms.

Activity

  1. changed the title [-]Run ./contrib/tst.sh on OSX (and Windows?) in github actions[/-] [+]Run ./contrib/test.sh on OSX (and Windows?) in github actions[/+] on Jul 14, 2025
  2. spacebear21 commented on Sep 19, 2025

    @spacebear21
    Collaborator

    As a macOS user myself, I'm not convinced that this is actually worth adding to CI. The macOS runners are slower and less reliable than the ubuntu ones, and changes that would only affect macOS (mostly just script changes I think) are relatively rare and can be caught quickly by those of us who run Macs.

  3. benalleng commented on Sep 23, 2025

    @benalleng
    Collaborator

    Following through that we don't really need these, after testing in #888 and with redis and docker removed the differences are just really minor and not worth the upkeep of these runners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions