Repository navigation
Update directory and ffi toml files where deps were incorrect - #1044
Merged
Merged
Conversation
benalleng
changed the title
There were 2 deps in the directory and ffi where the versions listed were off compared to the rest of the repo. The offenders payjoin-directory tokio: 1.23.31 (doesn't exist) and uniffi: 0.29.1 (the build dep differed from the main)
benalleng
force-pushed
the
cli-directory-dep-drift
branch
from
September 4, 2025 19:12
0c88670 to
be86689
Compare
Collaborator
Pull Request Test Coverage Report for Build 17474248282Details
💛 - Coveralls |
arminsabouri
approved these changes
Sep 5, 2025
Contributor
There was a problem hiding this comment.
utACK be86689
@benalleng For common deps (like tokio) would it make sense to just have workspace dependencies? Maybe not if different crates have different MSRV
Collaborator
Author
|
Now that we have everything updated to 1.85.0 I think its probably ok to do this. Though I probably want to wait until we get the ohttp-relay merged into the mono repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were 2 deps in the directory and ffi where the versions listed were off compared to the rest of the repo.
The offenders
payjoin-directory tokio: 1.23.31(doesn't exist) anduniffi: 0.29.1(the build dep differed from the main)Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.