Skip to content

Use HasReplyableErrorTransition in reply error typestate - #1130

Merged
arminsabouri merged 1 commit into
payjoin:masterfrom
arminsabouri:use-ffi-hasreplyerror-transition
Oct 1, 2025
Merged

arminsabouri merged 1 commit into
payjoin:masterfrom
arminsabouri:use-ffi-hasreplyerror-transition

Conversation

@arminsabouri

Copy link
Copy Markdown
Contributor

The ffi HasReplyableError typestate is incorrectly using using the PayjoinProposalTransition state transition.

Pull Request Checklist

Please confirm the following before requesting review:

The ffi `HasReplyableError` typestate is incorrectly using
using the `PayjoinProposalTransition` state transition.
@coveralls

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 18171737202

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.561%

Totals Coverage Status
Change from base Build 18170954588: 0.0%
Covered Lines: 8654
Relevant Lines: 10234

💛 - Coveralls

@spacebear21 spacebear21 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, thanks

@arminsabouri
arminsabouri merged commit 6c8a6df into payjoin:master Oct 1, 2025
14 checks passed
@arminsabouri
arminsabouri deleted the use-ffi-hasreplyerror-transition branch October 1, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants