[benalleng]

Closes #1606

Referencing this chain of comments #1558 (comment) I have merged the Cancel and Failure variants in the sender and receiver for a unified Aborted variant in SessionOutcome. As the outcome can now be inferred from the event log we no longer need outcome to be explicitly in the PendingFallback struct as well.

Deepseek coded this one up with the expectation that this was mostly a rewiring of the existing variants to be merged.

Pull Request Checklist

Please confirm the following before requesting review:

• I have disclosed my use of
  AI
  in the body of this PR.
• I have read CONTRIBUTING.md and rebased my branch to produce hygienic commits.

[coveralls]

Coverage Report for CI Build 27018036514

Coverage increased (+0.02%) to 85.413%

Details

• Coverage increased (+0.02%) from the base build.
• Patch coverage: 22 uncovered changes across 4 files (75 of 97 lines covered, 77.32%).
• 3 coverage regressions across 2 files.

Uncovered Changes

File	Changed	Covered	%
payjoin/src/core/receive/v2/mod.rs	46	36	78.26%
payjoin-cli/src/app/v2/mod.rs	6	0	0.0%
payjoin/src/core/send/v2/mod.rs	7	2	28.57%
payjoin/src/core/send/v2/session.rs	3	2	66.67%
Total (5 files)	97	75	77.32%

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File	Lines Losing Coverage	Coverage
payjoin-cli/src/app/v2/mod.rs	2	51.75%
payjoin/src/core/receive/v2/mod.rs	1	91.16%

---

Coverage Stats

Relevant Lines:	14602
Covered Lines:	12472
Line Coverage:	85.41%
Coverage Strength:	373.66 hits per line

---

💛 - Coveralls

[DanGould]

The meat of it looks ok, but DeepSeek may have not picked up on our CONTRIBUTORS.md conventions. Weird history

It's small enough that I'm ok squashing and merging and writing a commit here on GitHub but worth flagging for the future

I lied, I didn't see the sender/receiver distinction

[benalleng]

Nope thats on me lol I can fix it 😅

[DanGould]

Oh no I've made this mistake before I overlooked that the sender/receiver words are different here. It think it's actually fine on second glance

[DanGould]

ACK cc3e046

clean history, pretty test, net delete 👍