Skip to content

Fix commented test assert - #1624

Merged
benalleng merged 1 commit into
payjoin:masterfrom
xstoicunicornx:uncomment-error-assert
Jun 8, 2026
Merged

benalleng merged 1 commit into
payjoin:masterfrom
xstoicunicornx:uncomment-error-assert

Conversation

@xstoicunicornx

Copy link
Copy Markdown
Collaborator

Summary

Small follow up introduced by #1558. Uncomments an assert in the process_error_response_fatal_with_fallback_enters_pending_fallback unit test.

Pull Request Checklist

Please confirm the following before requesting review:

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27147236330

Coverage increased (+0.001%) to 85.371%

Details

  • Coverage increased (+0.001%) from the base build.
  • Patch coverage: 2 of 2 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 14690
Covered Lines: 12541
Line Coverage: 85.37%
Coverage Strength: 371.45 hits per line

💛 - Coveralls

@xstoicunicornx
xstoicunicornx requested a review from benalleng June 8, 2026 15:27

@benalleng benalleng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b6cb0a0 whoopsie

@benalleng
benalleng merged commit 183ecae into payjoin:master Jun 8, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants