Repository navigation
Conversation
Collaborator
Coverage Report for CI Build 37464696876Coverage increased (+0.2%) to 87.724%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This comment was marked as resolved.
This comment was marked as resolved.
benalleng
force-pushed
the
payjoin-ffi-mutants
branch
from
September 29, 2026 18:56
165ee5d to
fdfe9d2
Compare
benalleng
force-pushed
the
payjoin-ffi-mutants
branch
from
October 5, 2026 17:03
fdfe9d2 to
13c67db
Compare
benalleng
force-pushed
the
payjoin-ffi-mutants
branch
from
October 5, 2026 18:02
988301c to
2fd60ff
Compare
benalleng
force-pushed
the
payjoin-ffi-mutants
branch
from
October 6, 2026 12:38
fac7f44 to
d72ce45
Compare
benalleng
marked this pull request as ready for review
October 6, 2026 12:38
Collaborator
Author
|
Done, I am happy with the +0.2% coverage from the ffi |
caarloshenriq
approved these changes
Oct 6, 2026
caarloshenriq
left a comment
caarloshenriq
left a comment
Contributor
There was a problem hiding this comment.
tACK
Ran the ffi tests, coverage, and cargo-mutants locally, all green. Solid coverage: 51 offline, deterministic tests behind _test-utils
Member
|
this branch seems fine, but we're closing it for now to take stuff off the plate. Looks like the issue needs a bit of fleshing out. Thanks for review @caarloshenriq but this one was a bit premature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1888
This adds both mutants coverage as well as coveralls tracking.
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.