Repository navigation
Bump payjoin version to 1.1.0 - #1899
Merged
Merged
Conversation
The cargo-semver-checks 0.50.0 derivation in the locked nixpkgs-unstable fails its own snapshot tests because the check phase cannot create a cache directory under HOME. That breaks building the release devShell, and with it the check-bump CI job. Add writableTmpDirAsHomeHook to its check inputs, as the open upstream fix NixOS/nixpkgs#563137 does. Once the lock picks up that fix the override is a no-op and can be removed.
Collaborator
Coverage Report for CI Build 35960763254Coverage remained the same at 86.869%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
benalleng
force-pushed
the
bump-payjoin-1-1
branch
from
September 23, 2026 18:27
ad79bb6 to
680469a
Compare
This is a minor release rather than a patch. It adds the arbitrary feature, deprecates the v2 SenderBuilder::new, and raises the minimum bitcoin and bitcoin-units versions, each of which is a minor change under Cargo's semver rules.
DanGould
force-pushed
the
bump-payjoin-1-1
branch
from
September 24, 2026 05:37
680469a to
ad71eb7
Compare
DanGould
marked this pull request as ready for review
September 24, 2026 05:37
Member
Author
|
Force-pushed to include the bitcoin-hpke bitcoinohttp bumps in the changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
payjointo 1.1.0 and moves every workspace dependent's requirement to match. The release is mostly validation hardening from the twelve PRs merged sincepayjoin-1.0.0, summarized in the new## 1.1.0section ofpayjoin/CHANGELOG.md, which also becomes the GitHub release notes. It is a minor release rather than a patch because it adds thearbitraryfeature (#1662), deprecates the v2SenderBuilder::new(#1884), and raises the minimumbitcoinandbitcoin-unitsversions (#1879).cargo semver-checksagainst 1.0.0 passes with no breaking changes.The first commit repairs the
.#releasedevShell, whichcheck-bumpruns in. The locked nixpkgs-unstablecargo-semver-checks0.50.0 fails its own tests in the nix sandbox because the check phase has no writable HOME. The commit addswritableTmpDirAsHomeHookthe same way NixOS/nixpkgs#563137 does, so the override can be dropped once the lock picks that up.Also moves payjoin onto bitcoin-hpke 0.20.0 and bitcoin-ohttp 0.7.0, now that both are on crates.io (#1817). Neither crate appears in payjoin's public API, so that bump does not change the version decision.
Disclosure: co-authored by Claude Code
Pull Request Checklist
Please confirm the following before requesting review: